New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #779 fix #723 update default value for settings #780

Open

gbarat87 wants to merge 1 commit into turnitin:develop from gbarat87:fix-unit-test-upstream

gbarat87 commented Nov 15, 2024 •

edited

Loading

The default value need to match the type of the setting:

admin_setting_configtext_int_only => the default value should be an INT
admin_setting_config_tii_secret_key => This extends admin_setting_configpasswordunmask But this class doesn't have param_type
The validate() method block the previous default value to be set to an empty string '' so an error is being raised. (Or replace the default value by null)
admin_setting_configselect => Require a default value to be part of the $testoptions

In order to re-test the update, a PHP Unit reinitialize must be done.


          fix turnitin#779 fix turnitin#723 update default value for settings

03ad004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet