Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add create_user_assign_to_group mod #25

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Add create_user_assign_to_group mod #25

merged 2 commits into from
Dec 5, 2023

Conversation

karanpopat
Copy link
Contributor

Checklist

  • Issue(s) linked

@karanpopat karanpopat self-assigned this Nov 24, 2023
vkumbha
vkumbha reviewed Nov 27, 2023
View reviewed changes
create_user_assign_to_group/create_user_assign_to_group.fp Outdated
}

output "assignment" {
value = step.pipeline.assign_user.response_body
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the assign_user pipeline in okta mod does not have any outputs, will this work?

vkumbha
vkumbha reviewed Nov 27, 2023
View reviewed changes
create_user_assign_to_group/create_user_assign_to_group.fp Outdated
pipeline = pipeline.assign_user
args = {
group_id = param.group_id
user_id = jsondecode(step.pipeline.create_user.user).id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the outputs of pipelines are wrapped in the attribute "output" right? does step.pipeline.create_user.user work here?

vkumbha
vkumbha requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@vkumbha vkumbha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karanpopat Please check comments. Thank you!

@cbruno10 cbruno10 merged commit d9a84ef into main Dec 5, 2023
@cbruno10 cbruno10 deleted the create_user_assign_to_group branch December 5, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbruno10 cbruno10 cbruno10 approved these changes

@vkumbha vkumbha vkumbha approved these changes

Assignees

@karanpopat karanpopat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karanpopat @cbruno10 @vkumbha