This repository has been archived by the owner on Aug 1, 2020. It is now read-only.
Allow integer rulers to be turned off at cmd line #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 12, 2013 21:25
Rulers that take an integer option did not accept 'off' or 'false' at the command line, essentially meaning that they could only be disabled through config. Refs turboladen#117, turboladen#118.
|
You are a stud and these changes are brilliant. I'll get them merged in, probably this coming weekend. |
|
Hey Andrew... The test that was failing was a result of me not working in a branch and starting work on #112. I made that failing test pending, pulled down your branch, merged in master, and the tests seem to be passing for me, but could you do the same? I'd just like to make sure that that did the trick before merging. Other than that, I'm ready to merge this in. |
|
Actually, I feel pretty confident that that change I made on master should do the trick--don't worry about the testing, @acrmp. |
turboladen
added a commit
that referenced
this pull request
Sep 27, 2013
Allow integer rulers to be turned off at cmd line
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Steve,
This is to allow boolean options to be disabled with 'off' at the command line. Related issues are #117 and #118.
I've based this change off of 6b645b0 as the build is failing against
HEADfor me.Thanks,
Andrew.