-
Notifications
You must be signed in to change notification settings - Fork 18
--max-lines-in-* don't accept 'off' or 'false' #117
Comments
Oh, I lied. |
Honestly, I'm not happy with how the config stuff turned out--I agree that it can be quite confusing if you try to do anything that's not default. It's also a PITA to test. :) Long term, I'd like to simplify that, but I'm not sure when I'll get to that. In the mean time, I'm open to suggestions and will try to get to them as I can. |
While I agree there's room for architectural improvement, in the meantime, this seems like the same bug as 118... |
BTW, if you're looking for an example of ways to represent configuration for these sorts of things, IMO, |
Rulers that take an integer option did not accept 'off' or 'false' at the command line, essentially meaning that they could only be disabled through config. Refs turboladen#117, turboladen#118.
The --max-lines-in options don't seem to have a way to turn them off. They don't accept 'false' or 'off' per the help:
invalid argument: --max-code-lines-in-class off (OptionParser::InvalidArgument)
invalid argument: --max-code-lines-in-class false (OptionParser::InvalidArgument)
0
seems to work but since "num-spaces-*" options all take 0 as a specific value and not to mean "disable", this is awfully confusing.The text was updated successfully, but these errors were encountered: