Skip to content

Commit

Permalink
remove FIRESTARTER_THREAD_AFFINITY flag from cmake. update CHANGELOG …
Browse files Browse the repository at this point in the history
…and README.
  • Loading branch information
marenz2569 committed Dec 9, 2024
1 parent ddd78ba commit be7dab9
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 12 deletions.
5 changes: 4 additions & 1 deletion CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,14 @@
$$ TODO
$$ TODO Version 2.x
$$ TODO - add results verification
$$ TODO - add AMD GPUs
$$ TODO - add more processors
$$ TODO - support for AArch64 (64 Bit ARM)
$$ TODO - support Infiniband interconnects
$$ TODO
$$ TODO Version 2.2
$$ TODO - added support for AMD GPUs
$$ TODO - support for thread binding on all supported platforms
$$ TODO - bug fixes related to thread binding with cgroups

Version 2.1.1
- Removed MacOS 11
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@ CMake option | Description
`FIRESTARTER_BUILD_TYPE` | Can be any of `FIRESTARTER`, `FIRESTARTER_CUDA`, `FIRESTARTER_ONEAPI`, or `FIRESTARTER_HIP`. Default `FIRESTARTER`
`FIRESTARTER_LINK_STATIC` | Link FIRESTARTER as a static binary. Note, dlopen is not supported in static binaries. This option is not available on macOS or with CUDA or OneAPI enabled. Default `ON`
`FIRESTARTER_BUILD_HWLOC` | Build hwloc dependency. Default `ON`
`FIRESTARTER_THREAD_AFFINITY` | Enable FIRESTARTER to set affinity to hardware threads. Default `ON`

When building `FIRESTARTER_ONEAPI` make sure that the Intel Math Kernel
Library (MKL) and the compiler `icx` and `icpx` can be found. Please provide
Expand Down
6 changes: 0 additions & 6 deletions cmake/BuildOptions.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,6 @@ endif()
option(FIRESTARTER_BUILD_HWLOC "Build hwloc dependency." ON)


# Use of thread affinity is enabled on linux per default.
if(${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
set(FIRESTARTER_THREAD_AFFINITY "Enable FIRESTARTER to set affinity to hardware threads." ON)
endif()


# Debug feature are enabled on linux per default.
if(${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
set(FIRESTARTER_DEBUG_FEATURES "Enable debug features" ON)
Expand Down
4 changes: 0 additions & 4 deletions cmake/BuildSettings.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ if (FIRESTARTER_DEBUG_FEATURES)
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DFIRESTARTER_DEBUG_FEATURES")
endif()

if (FIRESTARTER_THREAD_AFFINITY)
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DFIRESTARTER_THREAD_AFFINITY")
endif()


# Not MSVC
if(NOT "${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
Expand Down

0 comments on commit be7dab9

Please sign in to comment.