Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add indication in the browser and cli that circuit is currently loading #51

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Anshgrover23
Copy link
Contributor

@Anshgrover23 Anshgrover23 commented Feb 1, 2025

/claim #29
Fixes #29

Reference video:

2025-02-02.18-54-08.mov

Copy link
Contributor

@ShiboSoftwareDev ShiboSoftwareDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is not for a loading screen, When the server refreshes and the circuit is still rendering you should indicate to the user that the circuit is rendering, because currently there is no feedback

@ShiboSoftwareDev
Copy link
Contributor

@Anshgrover23
something like this:
image
or this:
image

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no SSE, you should propose an approach in the issue, the whole reason we have a standard file server is because the server was getting too custom and complicated in the old CLI. The server must remain incredibly simple with just and event bus and api for updating files.

If we're in the process of rendering, you could simply emit an event CIRCUIT_RENDERING_STARTED and CIRCUIT_RENDERING_FAILED or CIRCUIT_RENDERING_FINISHED (then subscribe to these in the browser)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

give indication in the browser and the cli that the circuit is currently loading
3 participants