fix: convert index.ts file extension to .tsx during cloning #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kom-senapati
force-pushed
the
fix/clone
branch
from
6a204db to
cca3d72
Compare
DrSensor
approved these changes
Feb 1, 2025
|
No need to approve, @DrSensor, as I have already requested a review from seve. |
seveibar
reviewed
Feb 2, 2025
| const fullPath = path.join(dirPath, filePath) | ||
| let fullPath = path.join(dirPath, filePath) | ||
| if (filePath === "index.ts") | ||
| fullPath = fullPath.replace(".ts", ".tsx") |
There was a problem hiding this comment.
we can't modify the files from the cloud (think of how many problems this would cause with version control), this issue is with the registry api storing package content in index.ts instead of index.tsx CC @imrishabh18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #48
Closes #48