-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nixvim): add otter, spectre, render-markdown #55
Conversation
Reviewer's Guide by SourceryThis pull request adds new plugins (otter, spectre, render-markdown) to the nixvim configuration, updates existing plugin configurations, and makes some minor changes to the README and other files. The changes primarily focus on enhancing the Neovim setup with additional functionality and improving the overall configuration structure. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tsandrini - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 3 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
allowedUDPPorts = [ 51820 ]; | ||
allowedUDPPorts = [ | ||
51820 | ||
4321 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 question (security): Explain the purpose of opening port 4321 in the firewall configuration
Port 4321 has been added to both allowed UDP and TCP ports in the firewall configuration. Could you provide more information about the service or application that requires this port to be open? This change could have security implications, so it's important to understand its necessity.
README.md
Outdated
@@ -16,6 +16,8 @@ | |||
1. [Troubleshooting](5-troubleshooting) | |||
1. [`Write error: disk full;` during `nixos-install`](write-error-disk-full-during-nixos-install) | |||
1. [Impurities](6-impurities) | |||
1. [Currently known impurities](61-currently-known-impurities) | |||
1. [Notes](62-notes) | |||
1. [References](7-references) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (documentation): Update table of contents to reflect new section title
The section '7. References' has been renamed to '7. Resources'. This change should be reflected in the table of contents for consistency.
README.md
Outdated
### 8.1 Major help | ||
|
||
These are people that are engrained in the nix community and whose work I/we | ||
use on a daily basis. I hope they will hapilly continue to be a part of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick (documentation): Fix typo: 'hapilly' should be 'happily'
Overview
Testing
Dependencies
Screenshots
Checklist
nix flake check
passes.Additional Notes
Summary by Sourcery
Add new plugins Otter, Spectre, and Render-Markdown to the Nixvim configuration, enhancing LSP support, search and replace functionality, and markdown rendering. Update the README with new sections on impurities and credits, and adjust Neovide scaling for improved user experience.
New Features:
Enhancements:
Documentation: