Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nixvim): add otter, spectre, render-markdown #55

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

tsandrini
Copy link
Owner

@tsandrini tsandrini commented Sep 16, 2024

Overview

Testing

Dependencies

Screenshots

Checklist

  • I have tested the relevant changes locally.
  • I have checked that nix flake check passes.
  • I have ensured my commits follow the project's commits guidelines.
  • I have checked that the changes follow a linear history.
  • (If applicable) I have commented any relevant parts of my code.
  • (If applicable) I have added appropriate unit/feature tests.
  • (If applicable) I have updated the documentation accordingly (in English).

Additional Notes

Summary by Sourcery

Add new plugins Otter, Spectre, and Render-Markdown to the Nixvim configuration, enhancing LSP support, search and replace functionality, and markdown rendering. Update the README with new sections on impurities and credits, and adjust Neovide scaling for improved user experience.

New Features:

  • Introduce the Otter plugin for LSP support in the Nixvim configuration.
  • Add the Spectre plugin for search and replace functionality in the editor.
  • Include the Render-Markdown plugin to enhance markdown rendering capabilities.

Enhancements:

  • Modify the Neovide configuration to adjust the scaling factor for better user experience.
  • Enable additional color schemes and plugins in the Nixvim configuration to enhance visual and functional aspects.

Documentation:

  • Update the README to include new sections on known impurities and additional notes.
  • Add a credits section to acknowledge contributors and resources in the Nixvim project.

@tsandrini tsandrini self-assigned this Sep 16, 2024
Copy link

sourcery-ai bot commented Sep 16, 2024

Reviewer's Guide by Sourcery

This pull request adds new plugins (otter, spectre, render-markdown) to the nixvim configuration, updates existing plugin configurations, and makes some minor changes to the README and other files. The changes primarily focus on enhancing the Neovim setup with additional functionality and improving the overall configuration structure.

File-Level Changes

Change Details Files
Added new Neovim plugins: otter, spectre, and render-markdown
  • Created new configuration files for spectre, render-markdown, and otter plugins
  • Added these plugins to the minimal and IDE profiles
  • Implemented basic setup for each new plugin
flake-parts/modules/nixvim/plugins/editor/spectre.nix
flake-parts/modules/nixvim/plugins/editor/render-markdown.nix
flake-parts/modules/nixvim/plugins/lsp/otter.nix
flake-parts/modules/nixvim/profiles/minimal.nix
flake-parts/modules/nixvim/profiles/ide.nix
Updated existing plugin configurations
  • Modified copilot-lua configuration
  • Updated cmp (completion) plugin settings
  • Adjusted conform (formatting) plugin configuration
  • Added more colorscheme options
flake-parts/modules/nixvim/plugins/editor/copilot-lua.nix
flake-parts/modules/nixvim/plugins/cmp/cmp.nix
flake-parts/modules/nixvim/plugins/lsp/conform.nix
flake-parts/modules/nixvim/profiles/minimal.nix
Improved README structure and content
  • Added new sections for known impurities and notes
  • Included a new 'Credits & Special thanks' section
README.md
Made minor adjustments to various configuration files
  • Updated Neovide scaling settings
  • Modified networking firewall configuration
  • Adjusted LSP server settings
flake-parts/modules/nixvim/neovide.nix
flake-parts/hosts/jetbundle/default.nix
flake-parts/modules/nixvim/plugins/lsp/lsp.nix

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tsandrini - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟡 Security: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 3 issues found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

allowedUDPPorts = [ 51820 ];
allowedUDPPorts = [
51820
4321
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 question (security): Explain the purpose of opening port 4321 in the firewall configuration

Port 4321 has been added to both allowed UDP and TCP ports in the firewall configuration. Could you provide more information about the service or application that requires this port to be open? This change could have security implications, so it's important to understand its necessity.

README.md Outdated
@@ -16,6 +16,8 @@
1. [Troubleshooting](5-troubleshooting)
1. [`Write error: disk full;` during `nixos-install`](write-error-disk-full-during-nixos-install)
1. [Impurities](6-impurities)
1. [Currently known impurities](61-currently-known-impurities)
1. [Notes](62-notes)
1. [References](7-references)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (documentation): Update table of contents to reflect new section title

The section '7. References' has been renamed to '7. Resources'. This change should be reflected in the table of contents for consistency.

README.md Outdated
### 8.1 Major help

These are people that are engrained in the nix community and whose work I/we
use on a daily basis. I hope they will hapilly continue to be a part of the
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (documentation): Fix typo: 'hapilly' should be 'happily'

README.md Show resolved Hide resolved
@tsandrini tsandrini merged commit bce9798 into main Sep 16, 2024
2 checks passed
@tsandrini tsandrini deleted the updates branch September 16, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant