[feat] Flexible security contexts #206
Open
+61
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to fully define the security contexts of their pods rather than only supporting a limited list. Previous format must be maintained for backwards compatibility, which necessitates the complex set of if statements.
This is meant to address these issues:
Tested locally, confirmed the following:
helm template charts/retool --values charts/retool/ci/test-install-values.yamlruns successfully without errorsecurityContext.enabled=false, no security context block is addedsecurityContext.values={}, the legacy values are usedsecurityContext.values, those values are overridden, ignoring the legacy valuesUpdate: changed PR to match telemetry deployment model of maintaining legacy params while providing the option to add extra custom ones.