Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extendParams #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

beshur
Copy link

@beshur beshur commented Oct 27, 2022

Problem: as per request of our team, we need to add custom prefix and postfix to strings, while using accented strategy.

In this pull-request I added the extendParams option to start command, as well as in CLI.

@tryggvigy
Copy link
Owner

tryggvigy commented Nov 25, 2022

Hey @beshur! What use-cases do you have for the prefix and postfix? Can you give an example?

@beshur
Copy link
Author

beshur commented Nov 25, 2022 via email

@tryggvigy
Copy link
Owner

@beshur which pseudo-localization method are you using? Are you dynamic pseudo localization all text on the page via the start() method or are you applying pseudo localization only to your own app strings via pseudoLocalize()?

Our QA team requested explicit prefix and suffix [!- and -!] to distinguish
from possible dynamic data in page.

Are the app strings not easily distinguishable from dynamic content already due to the pseudo localization (all the added accents and elongation)?

I'm trying to understand your usecase better. Perhaps adding support for a function to post-process the pseudo-localized strings could be possible. That way you could add you own pre- and post-fixes.

@beshur
Copy link
Author

beshur commented Nov 28, 2022

I'm using pseudo-localization for the strings, with pseudoLocalize().

Are the app strings not easily distinguishable from dynamic content already due to the pseudo localization (all the added accents and elongation)?

I guess our QA team is following the best practices from other people.
It's definitely much easier to distinguish when it the strings are wrapped with [!- -!].

Perhaps adding support for a function to post-process the pseudo-localized strings could be possible

Yes, of course, but since there is already prefix and postfix options in the strategies, I could not see why I should not use those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants