-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated text expansion feature #35
Open
amramadan
wants to merge
13
commits into
tryggvigy:master
Choose a base branch
from
amramadan:feature_update_text_expansion
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Updated text expansion feature #35
amramadan
wants to merge
13
commits into
tryggvigy:master
from
amramadan:feature_update_text_expansion
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Text expansion was an emulated 30%. Rather here it is updated to match IBM standards as mentioned here https://www.w3.org/International/articles/article-text-size.
all strings were lowered to smaller case this has been fixed. Also, the number of repeated characters was a fixed now its dependant on the ratio to get the required string length.
tryggvigy
reviewed
Jan 25, 2021
tryggvigy
reviewed
Jan 25, 2021
tryggvigy
reviewed
Jan 25, 2021
tryggvigy
reviewed
Jan 25, 2021
tryggvigy
reviewed
Jan 25, 2021
tryggvigy
reviewed
Jan 25, 2021
In the case where we used to get the substring from the reversed string, in some cases the first character may occur once and get truncated. However, in this update we ensure that the first character is never disregarded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text expansion was an emulated 30%. Rather here it is updated to match IBM standards as mentioned here https://www.w3.org/International/articles/article-text-size.