Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated text expansion feature #35

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

amramadan
Copy link
Contributor

Text expansion was an emulated 30%. Rather here it is updated to match IBM standards as mentioned here https://www.w3.org/International/articles/article-text-size.

Text expansion was an emulated 30%. Rather here it is updated to match IBM standards as mentioned here https://www.w3.org/International/articles/article-text-size.
all strings were lowered to smaller case this has been fixed. Also, the number of repeated characters was a fixed now its dependant on the ratio to get the required string length.
src/localize.js Outdated Show resolved Hide resolved
src/localize.js Outdated Show resolved Hide resolved
src/localize.test.js Outdated Show resolved Hide resolved
In the case where we used to get the substring from the reversed string, in some cases the first character may occur once and get truncated. However, in this update we ensure that the first character is never disregarded.
@amramadan
Copy link
Contributor Author

@tryggvigy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants