Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: credential issuance history store #1468

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

mishasizov-SK
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 11, 2023
@mishasizov-SK mishasizov-SK force-pushed the fix_issuance_history_store branch from 85704b6 to 1b17279 Compare October 11, 2023 17:43
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c4ac6b7) 85.48% compared to head (1b17279) 85.52%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1468      +/-   ##
==========================================
+ Coverage   85.48%   85.52%   +0.04%     
==========================================
  Files         165      166       +1     
  Lines       10367    10380      +13     
==========================================
+ Hits         8862     8878      +16     
+ Misses       1097     1092       -5     
- Partials      408      410       +2     
Files Coverage Δ
cmd/vc-rest/startcmd/start.go 80.77% <100.00%> (-0.21%) ⬇️
...onent/credentialstatus/credentialstatus_service.go 81.76% <100.00%> (+1.50%) ⬆️
...entialstatus/component/credentialstatus_wrapper.go 82.60% <100.00%> (+3.12%) ⬆️
pkg/restapi/v1/issuer/controller.go 91.52% <ø> (ø)
...service/issuecredential/issuecredential_service.go 94.73% <100.00%> (ø)
...issuancehistorystore/vc_issuance_histsory_store.go 89.83% <84.21%> (-3.16%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fqutishat fqutishat merged commit 89c3811 into trustbloc:main Oct 11, 2023
9 checks passed
@mishasizov-SK mishasizov-SK deleted the fix_issuance_history_store branch November 6, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants