-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update kms-go&vc-go, use kms-crypto wrappers #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moopli
force-pushed
the
kmscrypto-refactor
branch
3 times, most recently
from
September 27, 2023 14:55
7d1249d
to
28c6134
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1439 +/- ##
==========================================
+ Coverage 85.51% 85.54% +0.03%
==========================================
Files 165 166 +1
Lines 10387 10378 -9
==========================================
- Hits 8882 8878 -4
+ Misses 1097 1091 -6
- Partials 408 409 +1
☔ View full report in Codecov by Sentry. |
Moopli
force-pushed
the
kmscrypto-refactor
branch
7 times, most recently
from
September 28, 2023 05:38
229ce04
to
0fefc30
Compare
Moopli
changed the title
wip: Kmscrypto refactor
refactor: update kms-go&vc-go, use kms-crypto wrappers
Sep 28, 2023
Moopli
force-pushed
the
kmscrypto-refactor
branch
9 times, most recently
from
September 28, 2023 20:31
1ce84bd
to
d5ed1bb
Compare
fqutishat
requested changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't merge now until we run stress test
fqutishat
approved these changes
Oct 11, 2023
Moopli
force-pushed
the
kmscrypto-refactor
branch
from
October 11, 2023 14:26
d5ed1bb
to
02a1534
Compare
Signed-off-by: Filip Burlacu <[email protected]>
Moopli
force-pushed
the
kmscrypto-refactor
branch
from
October 11, 2023 14:52
02a1534
to
d24e445
Compare
rolsonquadras
approved these changes
Oct 11, 2023
skynet2
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.