Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update kms-go&vc-go, use kms-crypto wrappers #1439

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

Moopli
Copy link
Contributor

@Moopli Moopli commented Sep 27, 2023

No description provided.

@cla-bot cla-bot bot added the cla-signed label Sep 27, 2023
@Moopli Moopli force-pushed the kmscrypto-refactor branch 3 times, most recently from 7d1249d to 28c6134 Compare September 27, 2023 14:55
@Moopli Moopli changed the title Kmscrypto refactor wip: Kmscrypto refactor Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (a165dca) 85.51% compared to head (d24e445) 85.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1439      +/-   ##
==========================================
+ Coverage   85.51%   85.54%   +0.03%     
==========================================
  Files         165      166       +1     
  Lines       10387    10378       -9     
==========================================
- Hits         8882     8878       -4     
+ Misses       1097     1091       -6     
- Partials      408      409       +1     
Files Coverage Δ
pkg/dataprotect/dataprotect.go 100.00% <100.00%> (ø)
pkg/dataprotect/nilcrypto.go 100.00% <100.00%> (ø)
pkg/kms/aws/service.go 98.92% <100.00%> (ø)
pkg/kms/aws/wrapper.go 100.00% <100.00%> (ø)
pkg/kms/key/creator.go 87.50% <100.00%> (+7.01%) ⬆️
cmd/vc-rest/startcmd/start.go 80.77% <50.00%> (-0.21%) ⬇️
pkg/kms/signer/arieskms.go 94.87% <86.66%> (-5.13%) ⬇️
pkg/kms/arieskms.go 68.68% <63.15%> (-5.83%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Moopli Moopli force-pushed the kmscrypto-refactor branch 7 times, most recently from 229ce04 to 0fefc30 Compare September 28, 2023 05:38
@Moopli Moopli changed the title wip: Kmscrypto refactor refactor: update kms-go&vc-go, use kms-crypto wrappers Sep 28, 2023
@Moopli Moopli force-pushed the kmscrypto-refactor branch 9 times, most recently from 1ce84bd to d5ed1bb Compare September 28, 2023 20:31
@Moopli Moopli marked this pull request as ready for review September 28, 2023 21:33
@Moopli Moopli requested a review from fqutishat September 28, 2023 21:34
Copy link
Contributor

@fqutishat fqutishat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't merge now until we run stress test

@Moopli Moopli force-pushed the kmscrypto-refactor branch from d5ed1bb to 02a1534 Compare October 11, 2023 14:26
@Moopli Moopli force-pushed the kmscrypto-refactor branch from 02a1534 to d24e445 Compare October 11, 2023 14:52
@skynet2 skynet2 merged commit 061a07b into trustbloc:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants