This repository has been archived by the owner on Mar 5, 2022. It is now read-only.
feat: Create trustbloc DID cli #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
+ Coverage 87.37% 87.89% +0.52%
==========================================
Files 22 22
Lines 895 909 +14
==========================================
+ Hits 782 799 +17
+ Misses 62 60 -2
+ Partials 51 50 -1
Continue to review full report at Codecov.
|
fqutishat
force-pushed
the
29
branch
4 times, most recently
from
1622028 to
e3b9a8d
Compare
sandrask
reviewed
Nov 2, 2020
| return nil, err | ||
| } | ||
|
|
||
| svcData, err := ioutil.ReadFile(serviceFile) //nolint: gosec |
There was a problem hiding this comment.
Is is practical for user to provide two files (one for services and one for public keys) in order to create did? This might be ok @troyronda
fqutishat
force-pushed
the
29
branch
3 times, most recently
from
bc47ebd to
e6b69df
Compare
|
@sandrask @troyronda @bstasyszyn I create task to refactor public key struct #191 |
fqutishat
force-pushed
the
29
branch
6 times, most recently
from
7b8e4d9 to
60287da
Compare
sandrask
reviewed
Nov 3, 2020
| } | ||
| } else { | ||
| pubKey, err = publicKeyFromPEM([]byte(keyString)) | ||
| if err != nil { |
There was a problem hiding this comment.
you could have error checking outside of if
There was a problem hiding this comment.
I didn't understand what I need to change here
bstasyszyn
approved these changes
Nov 3, 2020
fqutishat
force-pushed
the
29
branch
2 times, most recently
from
5d3e2f1 to
8a890dc
Compare
closes trustbloc#29 Signed-off-by: Firas Qutishat <[email protected]>
sandrask
approved these changes
Nov 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #29
Signed-off-by: Firas Qutishat [email protected]