Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: general house keeping, tflint, tfsort, update CI tools #351

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

esacteksab
Copy link
Contributor

  • chore(deps): update things
  • chore: tflint and tfsort variables
  • docs: update readme

@esacteksab
Copy link
Contributor Author

The biggest change was adding a type to var.container_volumes. I'm not entirely certain I captured it correctly. I referenced a config on an existing project:

efs_instance_id       = aws_efs_file_system.main.id
  container_volumes = [{
    "name" = var.efs.volume_name,
    "efs_volume_configuration" = {
      access_point_id         = aws_efs_access_point.mi_files.id,
      transit_encryption      = "ENABLED"
      transit_encryption_port = 10000
    }
  }]

I also replaced join("", object) with one(object), TF docs explains one(). Hopefully I did this correctly.

@esacteksab esacteksab requested a review from a team January 18, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant