build(circleci): Save and link to CircleCI artifact #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Save storybook as artifact and link GitHub deployment to it
ahobson
force-pushed
the
adh-storybook-artifact
branch
from
c0ffe49 to
f6783c4
Compare
ahobson
changed the title
ahobson
requested review from
brandonlenz,
gidjin,
haworku,
sarboc,
SirenaBorracha,
suzubara and
tinyels
as code owners
|
The Happo task also builds storybook, but I'm not sure how to save the copy it builds, so we're doing 2x the work for now. If it becomes a bigger deal, we can look into fixing/optimizing things |
Just linking this open issue, which is relevant and I remembered seeing before: happo/happo.io#86 |
brandonlenz
approved these changes
Feb 24, 2021
I worked with @eeeady on this, so I think we're good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deploy storybook as an artifact in CircleCI and link to it from a GitHub deployment
Related Issues or PRs
How To Test
Look at the PR and follow the link to the deployment
Screenshots (optional)