Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated manifest.json to v3 #30

Closed
wants to merge 1 commit into from
Closed

Updated manifest.json to v3 #30

wants to merge 1 commit into from

Conversation

clintonb
Copy link

Fixes #29

theohighnote
theohighnote reviewed Mar 21, 2024
View reviewed changes
Copy link

@theohighnote theohighnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errors when loading extension:
'background.scripts' requires manifest version of 2 or lower.
'browser_action' requires manifest version of 2 or lower.
'webRequestBlocking' requires manifest version of 2 or lower.

@clintonb
Copy link
Author

@theohighnote on Chrome or Firefox?

@theohighnote
Copy link

theohighnote commented Mar 21, 2024 •
edited
Loading

@theohighnote on Chrome or Firefox?

Tested in Chrome

@clintonb
Copy link
Author

Fixing this will require more time than I have. I've opted to adapt https://github.com/nownabe/golink/tree/main/extension since it is more up-to-date.

@clintonb clintonb closed this Mar 26, 2024
@clintonb clintonb deleted the clintonb/manifest-v3 branch March 26, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theohighnote theohighnote theohighnote left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chrome Manifest need to be upgraded to v3
2 participants
@clintonb @theohighnote