More verbose options #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S. There are some issues with the opower file and git. I am checking it. It could be a line-ending issue... |
tronikos
reviewed
Mar 31, 2024
README.md
Outdated
| @@ -80,8 +80,8 @@ pytest | |||
|
|
|||
| # Run demo | |||
| python src/demo.py --help | |||
| # To output debug logs to a file, change DEBUG_LOG_RESPONSE to True in opower.py and run: | |||
| python src/demo.py --verbose 2> out.txt | |||
| # To output debug logs to a file run: | |||
There was a problem hiding this comment.
# To output debug logs and API responses to a file run:
There was a problem hiding this comment.
Updated. I fixed diff and also updated logging for smud provider
BrianHenryIE
added a commit
to BrianHenryIE/opower-smud
that referenced
this pull request
Apr 3, 2024
tronikos
added a commit
that referenced
this pull request
Apr 3, 2024
* first try at adding smud * login sucessful unable to parse opower token * not yet working, token is in history * proof of concept getsokta token this works as far as getting the token * SMUD, tested. * @v-yarotsky code review changes * Fix redirects logging Was previously showing the requested URL and the redirect and stating there were two redirects (where there was two requests) * Ignore `.env.secret` * Add pytest to optional dependencies * use `len()` * If we already have a cookie, return early if it is valid. * 0.4.0 * Update __init__.py src/opower/__init__.py:5:5: F401 [*] `.opower.DEBUG_LOG_RESPONSE` imported but unused * Update test_smud.py * Set types for mypy * Use Optional[str] * Update README.md * Update smud.py * Update `-vv` changes from #76 * Delete cookies if they don't work. * Update smud.py * Update smud.py --------- Co-authored-by: andylittle <[email protected]> Co-authored-by: tronikos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tronikos What do you think about this? It's a little bit ugly, but I don't have any better ideas for now. Maybe adding more constants for the
-vand-vvoptions?