Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Add Focus Handling for Autocomplete Input in Table Cells #3047

Merged

Conversation

prashanthr6383
Copy link
Collaborator

@prashanthr6383 prashanthr6383 commented Nov 29, 2024

Description

References

  • Add focus method to auto-complete
  • Add Focus to the autocomplete in Table when edit mode

Fixes #3044

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@prashanthr6383 prashanthr6383 requested a review from a team as a code owner November 29, 2024 12:53
@prashanthr6383 prashanthr6383 linked an issue Nov 29, 2024 that may be closed by this pull request
@prashanthr6383 prashanthr6383 marked this pull request as draft November 29, 2024 12:53
Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit 752aaf5
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/674eb24ab4924500085307d8
😎 Deploy Preview https://deploy-preview-3047--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 36 (🔴 down 11 from production)
Accessibility: 75 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@prashanthr6383 prashanthr6383 marked this pull request as ready for review December 3, 2024 07:31
Copy link

@jewel-shajan jewel-shajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing completed and ready for PR Review.

@coliff coliff requested a review from saravananrmsmy December 3, 2024 12:55
@coliff coliff merged commit c5fe88c into main Jan 6, 2025
11 checks passed
@coliff coliff deleted the 3044-table-autocomplete-single-selection-to-activate-edit-mode branch January 6, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: Add Focus Handling for Autocomplete Input in Table Cells
4 participants