Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input: Add primary-font to input elements designed to display text #2354

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

austinoneil
Copy link
Contributor

@austinoneil austinoneil commented Mar 27, 2024

Description

Adds font-family: $primary-font to input elements that display some form of text.

References #2353

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Added the following to index.html:

<modus-text-input
      label="Text Input (Search Icon)"
      placeholder="Placeholder"
      include-search-icon
      required></modus-text-input>
    <modus-number-input
      label="Number Input Demo 1"
      placeholder="Placeholder"
      required="true"></modus-number-input>
    <modus-date-picker
      helper-text="mmm dd, yyyy"
      label="Single date"
      allowed-chars-regex="[\d\/]"
      format="mmm dd, yyyy"
      value="2022-12-22"></modus-date-input>
      <modus-time-picker
        label="Time"
        ampm="true"
        value="23:39"
        placeholder="12:00 AM"
        helper-text="hh:mm AM/PM"></modus-time-picker>

Also put "Times New Roman" as the first element in $primary-font (just as a visual indicator that my changes are, in fact, effective and the inspector isn't mistaken)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@austinoneil austinoneil requested a review from coliff as a code owner March 27, 2024 04:47
Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/66061939bd2016706678b3e0
😎 Deploy Preview https://deploy-preview-2354--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff coliff changed the title Add primary-font to input elements designed to display text Input: Add primary-font to input elements designed to display text Mar 27, 2024
@coliff coliff added the bug Something is wrong and needs to be addressed label Mar 27, 2024
@austinoneil austinoneil force-pushed the fix-input-font-face branch from fd3ed1b to 9b7fc2f Compare March 28, 2024 16:32
@austinoneil
Copy link
Contributor Author

I have squashed this into one commit as requested in the contributing guidelines.

@cjwinsor cjwinsor merged commit 69d11e1 into trimble-oss:main Mar 29, 2024
8 checks passed
@cjwinsor cjwinsor added modus-time-picker and removed trimble-technology Trimble Techonology labels Mar 29, 2024
austinoneil added a commit to austinoneil/modus-web-components that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants