Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Picker: Fixes a few usability / accessibility issues #2344

Merged

Conversation

coliff
Copy link
Member

@coliff coliff commented Mar 25, 2024

Description

Fixes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Fixes:
- The disabled buttons should not have hover states - let's add pointer-events: none CSS
- The title could have role="header"
- The calendar dates can have type="button" (fixes this Webhint warning: webhint.io/docs/user-guide/hints/hint-button-type)
@coliff coliff linked an issue Mar 25, 2024 that may be closed by this pull request
Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit 333fd31
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/66012de71e1da900089e1ca9
😎 Deploy Preview https://deploy-preview-2344--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 27 (no change from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff coliff added 1 1 story point bug Something is wrong and needs to be addressed accessibility labels Mar 25, 2024
@coliff coliff requested a review from cjwinsor March 25, 2024 08:23
@cjwinsor cjwinsor merged commit b128b28 into main Mar 26, 2024
9 checks passed
@cjwinsor cjwinsor deleted the 2343-date-picker-a-few-usability-accessibility-issues branch March 26, 2024 22:27
austinoneil pushed a commit to austinoneil/modus-web-components that referenced this pull request Apr 4, 2024
…s#2344)

Fixes:
- The disabled buttons should not have hover states - let's add pointer-events: none CSS
- The title could have role="header"
- The calendar dates can have type="button" (fixes this Webhint warning: webhint.io/docs/user-guide/hints/hint-button-type)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 1 story point accessibility bug Something is wrong and needs to be addressed modus-date-picker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date Picker: A few usability / accessibility issues
2 participants