-
-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Engine 2.0 (alpha) #1575
Open
nicktrn
wants to merge
384
commits into
main
Choose a base branch
from
run-engine-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Run Engine 2.0 (alpha) #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the heartbeat timeouts configurable via engine options
…e of my current thoughts
…eys, this will be needed for debounce for example
…tempt is created)
…un engine. With a test
I am really looking forward for this change... Any ETA when we will be able to try it out? At least Alpha? |
* Return isCached from the trigger API endpoint * Fix for the wrong type when blocking a run * Render the idempotent run in the inspector * Event repository for idempotency * Debug events off by default, added an admin toggle to show them * triggerAndWait idempotency span * Some improvements to the reference idempotency task * Removed the cached tracing from the SDK * Server-side creating cached span * Improved idempotency test task * Create cached task spans in a better way * Idempotency span support inc batch trigger * Simplified how the spans are done, using more of the existing code * Improved the idempotency test task * Added Waitpoint Batch type, add to TaskRunWaitpoint with order * Pass batch ids through to the run engine when triggering * Added batchIndex * Better batch support in the run engine * Added settings to batch trigger service, before major overhaul * Allow the longer run/batch ids in the filters * Changed how batching works, includes breaking changes in CLI * Removed batch idempotency because it gets put on the runs instead * Added `runs` to the batch.retrieve call/API * Set firstAttemptStartedAt when creating the first attempt * Do nothing when receiving a BATCH waitpoint * Some fixes in the new batch trigger service… mostly just passing missing optional params through * Tweaked the idempotency test task for more situations * Only block with a batch if it’s a batchTriggerAndWait… 🤦♂️ * Added another case to the idempotency test task: multiple of the same idempotencyKey in a single batch * Support for the same run multiple times in the same batch * Small tweaks * Make sure to complete batches, even if they’re not andWait ones * Export RunDuplicateIdempotencyKeyError from the run engine
@@ -24,6 +24,13 @@ | |||
node-version: 20.11.1 | |||
cache: "pnpm" | |||
|
|||
# ..to avoid rate limits when pulling images | |||
- name: 🐳 Login to DockerHub | |||
uses: docker/login-action@v3 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Unpinned 3rd party Action '🧪 Unit Tests' step uses 'docker/login-action' with ref 'v3', not a pinned commit hash
Uses Step
Error loading related location
Loading # Conflicts: # apps/webapp/app/models/runtimeEnvironment.server.ts # apps/webapp/app/v3/eventRepository.server.ts # apps/webapp/app/v3/marqs/sharedQueueConsumer.server.ts # apps/webapp/app/v3/models/workerDeployment.server.ts # apps/webapp/app/v3/services/triggerTask.server.ts # packages/cli-v3/src/build/bundle.ts # packages/cli-v3/src/commands/login.ts # packages/cli-v3/src/dev/devSession.ts # packages/core/src/v3/config.ts # packages/core/src/v3/errors.ts # packages/core/src/v3/runtime/devRuntimeManager.ts # packages/core/src/v3/runtime/prodRuntimeManager.ts # packages/rsc/package.json # packages/trigger-sdk/src/v3/shared.ts # pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good luck @coderabbitai