Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Engine 2.0 (alpha) #1575

Open
wants to merge 384 commits into
base: main
Choose a base branch
from
Open

Run Engine 2.0 (alpha) #1575

wants to merge 384 commits into from

Conversation

nicktrn
Copy link
Collaborator

@nicktrn nicktrn commented Dec 17, 2024

Good luck @coderabbitai

… the heartbeat timeouts configurable via engine options
…eys, this will be needed for debounce for example
@rossanmol
Copy link

I am really looking forward for this change... Any ETA when we will be able to try it out? At least Alpha?

* Return isCached from the trigger API endpoint

* Fix for the wrong type when blocking a run

* Render the idempotent run in the inspector

* Event repository for idempotency

* Debug events off by default, added an admin toggle to show them

* triggerAndWait idempotency span

* Some improvements to the reference idempotency task

* Removed the cached tracing from the SDK

* Server-side creating cached span

* Improved idempotency test task

* Create cached task spans in a better way

* Idempotency span support inc batch trigger

* Simplified how the spans are done, using more of the existing code

* Improved the idempotency test task

* Added Waitpoint Batch type, add to TaskRunWaitpoint with order

* Pass batch ids through to the run engine when triggering

* Added batchIndex

* Better batch support in the run engine

* Added settings to batch trigger service, before major overhaul

* Allow the longer run/batch ids in the filters

* Changed how batching works, includes breaking changes in CLI

* Removed batch idempotency because it gets put on the runs instead

* Added `runs` to the batch.retrieve call/API

* Set firstAttemptStartedAt when creating the first attempt

* Do nothing when receiving a BATCH waitpoint

* Some fixes in the new batch trigger service… mostly just passing missing optional params through

* Tweaked the idempotency test task for more situations

* Only block with a batch if it’s a batchTriggerAndWait… 🤦‍♂️

* Added another case to the idempotency test task: multiple of the same idempotencyKey in a single batch

* Support for the same run multiple times in the same batch

* Small tweaks

* Make sure to complete batches, even if they’re not andWait ones

* Export RunDuplicateIdempotencyKeyError from the run engine
@@ -24,6 +24,13 @@
node-version: 20.11.1
cache: "pnpm"

# ..to avoid rate limits when pulling images
- name: 🐳 Login to DockerHub
uses: docker/login-action@v3

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action '🧪 Unit Tests' step
Uses Step
uses 'docker/login-action' with ref 'v3', not a pinned commit hash
matt-aitken and others added 24 commits January 17, 2025 18:15
# Conflicts:
#	apps/webapp/app/models/runtimeEnvironment.server.ts
#	apps/webapp/app/v3/eventRepository.server.ts
#	apps/webapp/app/v3/marqs/sharedQueueConsumer.server.ts
#	apps/webapp/app/v3/models/workerDeployment.server.ts
#	apps/webapp/app/v3/services/triggerTask.server.ts
#	packages/cli-v3/src/build/bundle.ts
#	packages/cli-v3/src/commands/login.ts
#	packages/cli-v3/src/dev/devSession.ts
#	packages/core/src/v3/config.ts
#	packages/core/src/v3/errors.ts
#	packages/core/src/v3/runtime/devRuntimeManager.ts
#	packages/core/src/v3/runtime/prodRuntimeManager.ts
#	packages/rsc/package.json
#	packages/trigger-sdk/src/v3/shared.ts
#	pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants