Add support for the frege-intellij plugin #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for the frege intellij plugin by - exposing the frege compiler jar as a dependency, so the plugin can recognize the standard library. - adding the name 'fregeRun' as that is used by the plugin to run files - add support for overriding the main module executed by runFrege so that arbitary files can be run by the plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for the frege intellij plugin by
recognize the standard library.
that arbitary files can be run by the plugin
I'm reopening this PR, since it's now been rebased and i dont know how to switch HEAD branches in github.
As to why this PR is neccessary / addressing some of the questions asked in the last PR:
The intellij-frege plugin (https://github.com/IntelliJ-Frege/intellij-frege) uses a build.gradle that contains all the download+build+repl+etc code, and ive been using this plugin as a substitute for that. However, this plugin and the generated build.gradle have a few differences (mainly:
fregeRunvsrunFrege, and specifying the project propertyclass_nameto run a specific module when using the green run arrow), so i added those two changes to therunFregetask.In addition to that i make both the frege jar and frege dependencies available on the java classpath, since that way they are per default included in the application plugin / shadow jar plugin and that way they are also indexed by intellij.
To that end, i also make the classes task depend on compileFrege so that frege compilation output is captured in the project jar.