Remove VSCode "post-build" task and .vscode/settings.json #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why would this file be removed? Isn't the idea that developers working with kohi follow an identical code style? The settings file does contain the formatting rules and also the colors for NOTEs, TODOs, etc. right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm requesting to remove
.vscode/settings.jsonfrom this repo. From my understanding, Travis no longer uses Visual Studio Code so hopefully this will not cause any annoyance.I find myself frequently deleting this file, then discarding that change over and over again whenever I work with Kohi in VS Code. Adding this file to
.gitignoreshould allow anybody working with Kohi to use their ownsettings.jsonfile instead.If you feel this change is not appropriate for this repo, please let me know!
Additionally-- I've removed the "post-build" task from
.vscode/tasks.jsonsince that process was removed in this commit: b9f1b52