This repository has been archived by the owner on May 10, 2018. It is now read-only.
Fix user_sync/repositories to not explode on GH errors #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenfuchs
changed the title
| @@ -90,7 +90,7 @@ def slugs | |||
| end | |||
|
|
|||
| def fetch | |||
| resources.map { |resource| fetch_resource(resource) }.map(&:to_a).flatten.compact | |||
| resources.map { |resource| fetch_resource(resource) }.compact.map(&:to_a).flatten | |||
There was a problem hiding this comment.
resources.flat_map { |resource| Array(fetch_resource(resource)) }😉
There was a problem hiding this comment.
much nicer, thanks :)
|
lgtm |
svenfuchs
force-pushed
the
sf-sync-user-exception
branch
from
f32c916 to
055c377
Compare
|
Works on staging (as in: user sync still works, not sure how to provoke the error) |
|
Let's roll this out next week! :-D |
|
Is this still something we should merge in? |
|
I guess? :D |
|
I'll look into this tomorrow :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://app.getsentry.com/travis-ci/travis-gatekeeper/group/34761999/