Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data provider page without logic #27

Merged
merged 7 commits into from
Aug 30, 2024
Merged

Conversation

Gutts-n
Copy link
Contributor

@Gutts-n Gutts-n commented Aug 30, 2024

Related issue: #12

Created data provider page without integration with backend

Code review to @luccasmmg or @demenech

…a provider page and added responsivity to the page
…a/tdc-data-portal into feature/data-provider-page
@Gutts-n Gutts-n requested review from luccasmmg and demenech August 30, 2024 04:37
Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tdc-data-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 8:18pm

frontend/src/components/data-provider/AddDataSection.tsx Outdated Show resolved Hide resolved
/>
</svg>
</div>
<LongArrowRightIcon className="rotate-90 md:rotate-0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these arrows look weird on mobile, but its up to you
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luccasmmg any suggestions to improve it since we don't have a responsive mockup :( ?

@Gutts-n Gutts-n changed the title WIP: Data provider page without logic Data provider page without logic Aug 30, 2024
@luccasmmg luccasmmg merged commit 6956ca1 into main Aug 30, 2024
2 of 3 checks passed
@demenech demenech deleted the feature/data-provider-page branch September 3, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants