Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add manual retries for submissions #719

Merged
merged 13 commits into from
Jan 17, 2025
Merged

Add manual retries for submissions #719

merged 13 commits into from
Jan 17, 2025

Conversation

nid90
Copy link
Member

@nid90 nid90 commented Jan 13, 2025 •
edited
Loading

  • Set the last_stable_status when setting the failure context before failing
  • Add a retryable? definition for all store submissions
  • Use the state machines defined on each StoreSubmission type to determine the transitions allowed from failed states and use the last stable status to determine the correct event to trigger on manual retry!
Screenshot 2025-01-15 at 1 14 16 PM

@nid90 nid90 marked this pull request as ready for review January 14, 2025 18:30
@nid90 nid90 requested a review from kitallis January 15, 2025 08:03
kitallis
kitallis approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@kitallis kitallis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🌟

@nid90 nid90 merged commit 8016ecb into main Jan 17, 2025
4 checks passed
@nid90 nid90 deleted the retry-submission branch January 17, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitallis kitallis kitallis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nid90 @kitallis