Support custom parameters in workflow run

app/controllers/config/release_platforms_controller.rb

@@ -70,7 +70,8 @@ def config_params
         ]
       ],
       release_candidate_workflow_attributes: [
-        :id, :identifier, :artifact_name_pattern
+        :id, :identifier, :artifact_name_pattern,
+        parameters_attributes: [:id, :name, :value, :_destroy]
       ],
       production_release_attributes: [
         :id,

app/libs/installations/bitbucket/api.rb

@@ -306,7 +306,8 @@ def trigger_pipeline!(repo_slug, pipeline_config, branch_name, inputs, commit_ha
             {
               key: "VERSION_CODE",
               value: inputs[:version_code]
-            }
+            },
+            *inputs[:parameters].map { |key, value| {key:, value:} }
           ]
         }
       }

app/libs/installations/bitrise/api.rb

@@ -72,7 +72,8 @@
             environments: [
               {mapped_to: "versionName", value: inputs[:build_version]},
               {mapped_to: "versionCode", value: inputs[:version_code]},
-              {mapped_to: "buildNotes", value: inputs[:build_notes] || ""}
+              {mapped_to: "buildNotes", value: inputs[:build_notes] || ""},
+              *inputs[:parameters].map { |mapped_to, value| {mapped_to:, value:} },
             ]
           },
 

app/libs/installations/github/api.rb

@@ -85,6 +85,7 @@ def run_workflow!(repo, id, ref, inputs, commit_hash, json_inputs_enabled = fals
         inputs
           .slice(:version_code, :build_notes)
           .merge(version_name: inputs[:build_version], commit_ref: commit_hash)
+          .merge(inputs[:parameters])
           .compact
           .to_json
           .then { {"tramline-input" => _1} }
@@ -93,7 +94,7 @@ def run_workflow!(repo, id, ref, inputs, commit_hash, json_inputs_enabled = fals
           versionCode: inputs[:version_code],
           versionName: inputs[:build_version],
           buildNotes: inputs[:build_notes]
-        }.compact
+        }.merge(inputs[:parameters]).compact
       end
 
       execute do

app/models/config/workflow.rb

@@ -15,6 +15,9 @@
   self.table_name = "workflow_configs"
 
   belongs_to :release_platform_config, class_name: "Config::ReleasePlatform"
+  has_many :parameters, class_name: "Config::WorkflowParameter", dependent: :destroy
+
+  accepts_nested_attributes_for :parameters, allow_destroy: true
 
   enum :kind, {internal: "internal", release_candidate: "release_candidate"}
   validates :identifier, :name, presence: true
@@ -24,13 +27,15 @@
       id: identifier,
       name: name,
       artifact_name_pattern: artifact_name_pattern,
-      kind: kind
+      kind: kind,
+      parameters: parameters.map(&:as_json),
     }
   end
 
   def self.from_json(json)
-    workflow = new(json.except("id")) # Exclude 'id' to ensure we don't overwrite an existing object
+    workflow = new(json.except("id", "parameters")) # Exclude 'id' to ensure we don't overwrite an existing object
     workflow.identifier = json["id"]
+    workflow.parameters = json["parameters"].map { |parameter| ::Config::WorkflowParameter.new(parameter) }
     workflow
   end
 end

app/models/config/workflow_parameter.rb

@@ -0,0 +1,26 @@
+# == Schema Information
+#
+# Table name: workflow_config_parameters
+#
+#  id          :bigint           not null, primary key
+#  name        :string           not null
+#  value       :string           not null
+#  created_at  :datetime         not null
+#  updated_at  :datetime         not null
+#  workflow_id :bigint           not null, indexed
+#
+class Config::WorkflowParameter < ApplicationRecord
+  self.table_name = "workflow_config_parameters"
+  belongs_to :workflow
+
+  validates :name, :value, presence: true
+  validates :name, uniqueness: true
+
+  def as_json(_options = {})
+    {
+      name:,
+      value:,
+      id:
+    }
+  end
+end

app/models/workflow_run.rb

@@ -218,6 +218,10 @@ def update_build_number!
   def workflow_inputs
     data = {version_code: build.build_number, build_version: release_version}
     data[:build_notes] = triggering_release.tester_notes if organization.build_notes_in_workflow?
+    data[:parameters] = {}
+    conf.parameters.each do |param|
+      data[:parameters][param.name] = param.value
+    end
     data
   end
 

app/views/config/release_platforms/_form.html.erb

@@ -25,6 +25,53 @@
           <%= render partial: "build_name_pattern_info" %>
           <div><%= rc_fields.labeled_text_field :artifact_name_pattern, "Build artifact name (optional)", placeholder: "Eg., build-abc.apk" %></div>
         </div>
+
+        <div class="flex flex-col gap-0.5">
+          <div data-controller="nested-form-ext" data-nested-form-ext-list-position-outlet="#release_candidate_workflow_additional_parameters" class="grid-cols-2 gap-2 pt-3">
+            <div class="pb-3">
+              <%= render V2::ButtonComponent.new(
+                scheme: :light,
+                type: :action,
+                size: :xs,
+                label: "Add a new parameter",
+                html_options: { data: { action: "nested-form-ext#add" } },
+                arrow: :none) do |b|
+                b.with_icon("plus.svg", rounded: false)
+              end %>
+            </div>
+            <ul data-controller="sortable-list-ext list-position"
+                data-sortable-list-ext-handle-value=".handle"
+                data-sortable-list-ext-list-position-outlet="#release_candidate_workflow_parameters"
+                data-list-position-initial-value=1
+                class="flex flex-col flex-1 item-gap-default"
+                id="release_candidate_workflow_parameters">
+              <% if rc_fields.object.parameters.present? %>
+                <div class="flex flex-row grid grid-cols-2">
+                  <p class="text-sm">Parameter Name</p>
+                  <p class="text-sm">Parameter Value</p>
+                </div>
+              <% end %>
+
+              <% rc_fields.object.parameters.each do |parameter| %>
+                <% rc_fields.fields_for :parameters, parameter do |parameter_form| %>
+                  <li class="nested-form-wrapper" data-new-record="false">
+                    <%= render partial: "parameter_form", object: parameter_form %>
+                  </li>
+                <% end %>
+              <% end %>
+
+              <template data-nested-form-ext-target="template">
+                <li class="nested-form-wrapper" data-new-record="true">
+                  <% rc_fields.fields_for :parameters, rc_fields.object.parameters.build, child_index: "NEW_RECORD" do |parameter_form| %>
+                    <%= render partial: "parameter_form", object: parameter_form %>
+                  <% end %>
+                </li>
+              </template>
+
+              <div data-nested-form-ext-target="target"></div>
+            </ul>
+          </div>
+        </div>
       </div>
     <% end %>
   <% end %>

app/views/config/release_platforms/_parameter_form.html.erb

@@ -0,0 +1,16 @@
+<div class="flex flex-row item-gap-default">
+  <%= parameter_form.hidden_field :id %>
+  <%= parameter_form.hidden_field :_destroy %>
+  <%= parameter_form.text_field_without_label :name, "Parameter name" %>
+  <%= parameter_form.text_field_without_label :value, "Parameter value" %>
+
+  <div class="flex item-gap-default ml-auto">
+    <%= render V2::ButtonComponent.new(
+      scheme: :naked_icon,
+      type: :action,
+      size: :none,
+      html_options: {data: {action: "nested-form-ext#remove"}}) do |b|
+      b.with_icon("v2/trash.svg", size: :md)
+    end %>
+  </div>
+</div>

app/views/config/release_platforms/_release_candidate_workflow_release_form.html.erb

@@ -0,0 +1,51 @@
+<% release_type = "#{kind}_release".to_sym %>
+
+<div class="grid gap-4">
+  <% section.F.fields_for release_type, section.F.object.send(release_type) || Config::ReleaseStep.new(kind: kind, release_platform_config: section.F.object) do |rr| %>
+    <%= rr.hidden_field :id, value: rr.object.id %>
+    <div data-controller="nested-form-ext"
+         data-nested-form-ext-list-position-outlet="#<%= release_type %>_additional_parameters"
+         class="grid gap-2 pt-3">
+      <div>
+        <%= render V2::ButtonComponent.new(
+          scheme: :light,
+          type: :action,
+          size: :xs,
+          label: "Add a new parameter",
+          html_options: { data: { action: "nested-form-ext#add" } },
+          arrow: :none) do |b|
+          b.with_icon("plus.svg", rounded: false)
+        end %>
+      </div>
+
+      <ul data-controller="sortable-list-ext list-position"
+          data-sortable-list-ext-handle-value=".handle"
+          data-sortable-list-ext-list-position-outlet="#<%= release_type %>_additional_parameters"
+          data-list-position-initial-value=1
+          class="flex flex-col item-gap-default"
+          id="<%= release_type %>_additional_parameters">
+        <% rr.object.additional_parameters.each_with_index do |submission, _index| %>
+          <li class="nested-form-wrapper" data-new-record="false">
+            <% rr.fields_for :submissions, submission do |submission_form| %>
+              <%= render "submissions_form", form: submission_form, submission_types: submission_types %>
+              <%= submission_form.hidden_field :number, value: submission.number, data: { list_position_target: "position" } %>
+              <%= submission_form.hidden_field :id, value: submission.id %>
+              <%= submission_form.hidden_field :_destroy %>
+            <% end %>
+          </li>
+        <% end %>
+
+        <template data-nested-form-ext-target="template">
+          <li class="nested-form-wrapper" data-new-record="true">
+            <% rr.fields_for :submissions, rr.object.submissions.build(submission_type: submission_types.first, auto_promote: false), child_index: "NEW_RECORD" do |submission_form| %>
+              <%= render "submissions_form", form: submission_form, submission_types: submission_types %>
+              <%= submission_form.hidden_field :number, data: { list_position_target: "position" } %>
+            <% end %>
+          </li>
+        </template>
+
+        <div data-nested-form-ext-target="target"></div>
+      </ul>
+    </div>
+  <% end %>
+</div>

db/migrate/20250105122540_create_workflow_config_parameters.rb

@@ -0,0 +1,11 @@
+class CreateWorkflowConfigParameters < ActiveRecord::Migration[7.2]
+  def change
+    create_table :workflow_config_parameters do |t|
+      t.string :name, null: false
+      t.string :value, null: false
+      t.references :workflow, null: false, foreign_key: {to_table: :workflow_configs}
+
+      t.timestamps
+    end
+  end
+end

spec/models/config/workflow_parameter_spec.rb

@@ -0,0 +1,5 @@
+require 'rails_helper'
+
+RSpec.describe Config::WorkflowParameter, type: :model do
+  pending "add some examples to (or delete) #{__FILE__}"
+end