Add prefix to tags in addition to suffix #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gitstart-app[bot]](https://avatars.githubusercontent.com/in/46283?s=60&v=4){kind=small}
|
Hi @kitallis, the PR is ready for review. |
kitallis
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
suggestion: I think we can make this controller generic at this point, instead of a domain controller. Something like a StringAffixController (affiix representing both prefix and suffix). This will take the base string and prefix and suffix and the specified separator.
| @@ -5,18 +5,22 @@ | |||
| hide_child: @train.tag_releases?) do |component| %> | |||
| <% component.with_child do %> | |||
| <section data-controller="help-text"> | |||
| <div data-controller="domain--release-suffix-help" | |||
| data-domain--release-suffix-help-version-value="<%= @train.version_current || @train.version_seeded_with || "1.0.0" %>" | |||
| data-domain--release-suffix-help-version-suffix-current-value="<%= @train.tag_suffix %>" | |||
There was a problem hiding this comment.
version-suffix-current-value was used to initialize the suffix value but the controller should be able to handle the initial values directly from the input fields
Since it's unnecessary, we removed it.
|
Hi @kitallis, |
nid90
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR achieve?
tag_prefixcolumn totrainstablerelease_suffix_help_controller.jsto a generic controllerstring_affix_controller.jsbaseString,prefix,suffixand the specifiedseparator.data-string-affix-prefix-current-valueanddata-string-affix-suffix-current-valueattributes as they are not needed for thestring-affixcontroller to function correctly.Demo
https://www.loom.com/share/74aefe260f3a412597c99ae00b560ce0