-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve page titles #701
Improve page titles #701
Conversation
@majjikishore007 Thank you for this PR, give us a few days this week to review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR overall looks good, @majjikishore007! Thank you. 🙇♀️
I have noted a slight improvement at one place, and some missing locales.
I will merge this once those are resolved!
- this got missed in the v2 migration
- The Continuous Backemrge Job loops around itself until a non-retryable issue occurs, or it goes through - By default, enable auto-merge for all PRs where auto-merge can be allowed - Retry finalize release when a post-release PR is closed Co-authored-by: Nivedita Priyadarshini <[email protected]>
@majjikishore007 Looks good! There is a minor lint issue that can be fixed by running |
@nid90, I have fixed the lint issues thanks |
@majjikishore007 Your PR is ready to be merged, but before we do so, we'd like you to sign our Contributor Agreement. It's a standard CLA based on the Clojure/Eclipse CA. Please fill and send to contributors AT tramline DOT app |
@kitallis I have signed and sent the document to the mentioned email address. do let me know if anything needs to be added more, thanks |
Closes: #580
Because:
We want our page titles to be more meaningful than "ORG_NAME | Tramline."
This Addresses:
en.yml
so we have more user-friendly, localized page titles.Quick demo :
https://www.loom.com/share/b4c3ad5e3e2d4961b3e045d7bb23756d?sid=a88ee43a-c3c4-4296-9019-10fa8b8bbbb1