Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve page titles #701

Merged
merged 16 commits into from
Dec 27, 2024
Merged

Improve page titles #701

merged 16 commits into from
Dec 27, 2024

Conversation

majjikishore007
Copy link
Contributor

Closes: #580

Because:
We want our page titles to be more meaningful than "ORG_NAME | Tramline."

This Addresses:

  • Adds an I18n-based setup in en.yml so we have more user-friendly, localized page titles.
  • Centralizes all title logic for making updates and maintenance simpler

Quick demo :
https://www.loom.com/share/b4c3ad5e3e2d4961b3e045d7bb23756d?sid=a88ee43a-c3c4-4296-9019-10fa8b8bbbb1

@kitallis kitallis self-requested a review December 20, 2024 12:23
@kitallis
Copy link
Member

@majjikishore007 Thank you for this PR, give us a few days this week to review it.

Copy link
Member

@nid90 nid90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR overall looks good, @majjikishore007! Thank you. 🙇‍♀️

I have noted a slight improvement at one place, and some missing locales.

I will merge this once those are resolved!

app/controllers/application_controller.rb Outdated Show resolved Hide resolved
config/locales/en.yml Show resolved Hide resolved
@kitallis kitallis removed their request for review December 26, 2024 13:40
@nid90
Copy link
Member

nid90 commented Dec 27, 2024

@majjikishore007 Looks good! There is a minor lint issue that can be fixed by running just lint. I will merge this once all the checks pass! ⭐

@majjikishore007
Copy link
Contributor Author

@nid90, I have fixed the lint issues thanks

@kitallis
Copy link
Member

@majjikishore007 Your PR is ready to be merged, but before we do so, we'd like you to sign our Contributor Agreement. It's a standard CLA based on the Clojure/Eclipse CA.

Please fill and send to contributors AT tramline DOT app

@majjikishore007
Copy link
Contributor Author

@kitallis I have signed and sent the document to the mentioned email address. do let me know if anything needs to be added more, thanks

@kitallis kitallis merged commit dbf2645 into tramlinehq:main Dec 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants