Skip to content

Commit

Permalink
Remove Step reference from intgeration disconnectable check
Browse files Browse the repository at this point in the history
  • Loading branch information
nid90 committed Dec 20, 2024
1 parent 7fb9640 commit 7ff1a05
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 1 addition & 2 deletions app/models/integration.rb
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,7 @@ def providable_error_message(meta)
end

def disconnectable?
return false if app.active_runs.exists?
Step.kept.where(integration: self).none?
app.active_runs.none?
end

def disconnect
Expand Down
3 changes: 2 additions & 1 deletion app/models/train.rb
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ def cancel_scheduled_releases!
end

def activatable?
automatic? && startable? && !active?
automatic? && !active?
end

def deactivatable?
Expand Down Expand Up @@ -417,6 +417,7 @@ def schedule_editable?
end

def hotfixable?
return false unless app.ready?
return false unless has_production_deployment?
return false if hotfix_release.present?
return false if hotfix_from.blank?
Expand Down

0 comments on commit 7ff1a05

Please sign in to comment.