Skip to content

Commit

Permalink
Fix span of adoption chart in release monitoring component
Browse files Browse the repository at this point in the history
  • Loading branch information
nid90 committed Jan 9, 2025
1 parent d0c697f commit 5a6ec4e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 2 additions & 2 deletions app/components/v2/release_monitoring_component.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
<% end %>

<% if show_release_health? %>
<div class="<%= full_span %> flex flex-col gap-y-2 border-default box-padding">
<div class="col-span-full flex flex-col gap-y-2 border-default box-padding">
<div class="flex justify-between items-center">
<h5 class="heading-5 uppercase">
<span>Overall Release Health: </span>
Expand Down Expand Up @@ -86,7 +86,7 @@

<% if :adoption_chart.in? metrics %>
<% if adoption_chart_data.present? %>
<div class="<%= full_span %>"><%= render ChartComponent.new(adoption_chart_data) %></div>
<div class="col-span-full"><%= render ChartComponent.new(adoption_chart_data) %></div>
<% end %>
<% end %>
</div>
4 changes: 0 additions & 4 deletions app/components/v2/release_monitoring_component.rb
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,6 @@ def grid_cols
"grid-cols-#{@cols}"
end

def full_span
"col-span-#{@cols}"
end

def show_release_health?
release_health_rules.present? && show_health?
end
Expand Down

0 comments on commit 5a6ec4e

Please sign in to comment.