-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 feat: MessageInputTextAreaに縦の伸長を追加 #4375
base: master
Are you sure you want to change the base?
Conversation
Preview (prod) → https://4375-prod.traq-preview.trapti.tech/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024-10-15.202542.mp4
ちょっと触ってみたけど、focusしたときにサイズが変わるのは仕様としてわかりにくい気がするので、大きさを自分で変えられるとかの方がいいのかなと思った。(スマホのときの使いやすさは要検討)
編集の挙動はこれで良さそう。
src/components/Main/MainView/MessageInput/MessageInputTextArea.vue
Outdated
Show resolved
Hide resolved
トグルボタンを用意してmax-heightの大小を切り替えられるようにする方針 |
6ef4f08
to
4566405
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4375 +/- ##
=========================================
- Coverage 8.83% 8.83% -0.01%
=========================================
Files 671 671
Lines 29444 29446 +2
Branches 524 524
=========================================
Hits 2601 2601
- Misses 26837 26839 +2
Partials 6 6 ☔ View full report in Codecov by Sentry. |
MessageInputではonFocusのみ、MessageEditorでは常に伸長するように
MessageInputTextAreaコンポーネントにexists-height-limitプロパティを追加し、MessageEditorでfalseに設定しました。
4566405
to
53d3919
Compare
MessageInputではonFocus時にそうでないときの2倍まで、MessageEditorは無制限に伸長するように