Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 feat: MessageInputTextAreaに縦の伸長を追加 #4375

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

reiroop
Copy link
Contributor

@reiroop reiroop commented Sep 27, 2024

MessageInputではonFocus時にそうでないときの2倍まで、MessageEditorは無制限に伸長するように

Copy link

@reiroop reiroop requested a review from nokhnaton September 27, 2024 15:56
@reiroop reiroop self-assigned this Sep 27, 2024
@reiroop reiroop added the design label Sep 27, 2024
Copy link
Contributor

@nokhnaton nokhnaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024-10-15.202542.mp4

ちょっと触ってみたけど、focusしたときにサイズが変わるのは仕様としてわかりにくい気がするので、大きさを自分で変えられるとかの方がいいのかなと思った。(スマホのときの使いやすさは要検討)
編集の挙動はこれで良さそう。

reiroop added a commit that referenced this pull request Oct 19, 2024
@reiroop reiroop marked this pull request as draft October 19, 2024 09:21
@reiroop
Copy link
Contributor Author

reiroop commented Oct 20, 2024

トグルボタンを用意してmax-heightの大小を切り替えられるようにする方針

@reiroop reiroop marked this pull request as ready for review January 26, 2025 10:05
reiroop added a commit that referenced this pull request Jan 26, 2025
@reiroop reiroop force-pushed the feat/stretch-message-input-text-area branch from 6ef4f08 to 4566405 Compare January 26, 2025 10:09
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 8.83%. Comparing base (451901e) to head (1fe967a).

Files with missing lines Patch % Lines
...nts/Main/MainView/MessageElement/MessageEditor.vue 0.00% 9 Missing ⚠️
...ain/MainView/MessageInput/MessageInputTextArea.vue 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #4375      +/-   ##
=========================================
- Coverage    8.83%   8.83%   -0.01%     
=========================================
  Files         671     671              
  Lines       29444   29446       +2     
  Branches      524     524              
=========================================
  Hits         2601    2601              
- Misses      26837   26839       +2     
  Partials        6       6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MessageInputではonFocusのみ、MessageEditorでは常に伸長するように
MessageInputTextAreaコンポーネントにexists-height-limitプロパティを追加し、MessageEditorでfalseに設定しました。
@reiroop reiroop force-pushed the feat/stretch-message-input-text-area branch from 4566405 to 53d3919 Compare February 2, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

メッセージが長くなったときに入力欄が縦に伸びてほしい
2 participants