Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control ↔ exec の API を追加 #195

Merged
merged 7 commits into from
Jan 28, 2025
Merged

Conversation

hayatroid
Copy link
Contributor

@hayatroid hayatroid commented Jan 23, 2025

issue

close #193

チェックリスト(nix)

  • ビルドが通る
  • license-check.shが通る

@hayatroid hayatroid self-assigned this Jan 23, 2025
@hayatroid hayatroid requested a review from comavius January 23, 2025 21:33
@hayatroid
Copy link
Contributor Author

見よう見まねで書いたのでおかしなところあったら言ってください.
MD に軽い説明を書きました.
https://md.trap.jp/ds2G202sT-So-9JLDQX8uA

Copy link
Member

@comavius comavius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

諸々レビューしました、諸々お願いします:pray-nya:

type: integer
description: 実行時間制限
example: 2000
readonlyFiles:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

説明不足でごめん: ファイルパスは環境変数として渡すからenvsがあるなら消してしまってもいいかも

type: string
description: 環境
example: env
connectionTimeLimit:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connection/execution time limitはjudge-control app側設定なので、代わりにback-judgeで定義されているoptional info(tl, ml, langみたいなやつ)を渡してほしいです

servers:
- url: https://api.server.test/v1
paths:
"/result":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/executeのresponseとして返した方が楽かも mustではないけど

description: Bad Request
security:
- bearerAuth: []
"/container":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これはawsがやってくれるという話になっていたはずだからzoiくんに確認をとってほしいです

@hayatroid hayatroid requested a review from comavius January 28, 2025 08:06
@hayatroid hayatroid merged commit 89b7de5 into develop Jan 28, 2025
6 checks passed
@hayatroid hayatroid deleted the feat/#193-control-exec-api branch January 28, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

judge control ↔ exec の API を書く
2 participants