-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pyzet query
for easier searching of knowledge inside ZK
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyzet starts to be more stateful, and it asks what to do next, after previous action (like adding, opening, printing) was finished. This is a huge change in the philosophy how to use the tool, but I really like the new flow. This is still big WIP, there are issues with a lot of tests, and very likely a lot of hidden bugs which I will be gradually fixing with time. I still believe that this is worth the effort, as working with the new flow is very convenient in my ZK repo with 500+ notes.
… modify Namespace
It seems that `side_effect` has to be used over `return_value`. `KeyboardInterrupt` seems to work pretty well as the 2nd side effect. I'm not sure if this is the best appraoch, but these tests were broken last time I modified the code which was 9 months ago, so for now I just want to fix them. Note that 3 tests still fail at this point.
TODO errors are skipped for now, as they can be closed before merging to main.
For now this is a single person project.
I observed it, but I'm not sure if this is really bad. I guess it's fine for now.
For now we can just merge it without bumping the version. This reverts commit 6d251fc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of idea suggested in #58.
TODO:
pyzet query