Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in korean docs #107

Merged
merged 2 commits into from
Feb 5, 2025
Merged

docs: fix typo in korean docs #107

merged 2 commits into from
Feb 5, 2025

Conversation

gwansikk
Copy link
Contributor

@gwansikk gwansikk commented Feb 4, 2025

Description

Congratulations on the new document. While reading the Korean document, I made some corrections to typos.

  • Fix typos in the Korean documentation.
  • Delete .DS_Store and add it to .gitignore.

Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

AS-IS TO-BE
image image
AS-IS TO-BE
image image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have performed a self-review of my own code.
  • My code is commented, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Further Comments

Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: 569987e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
overlay-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 6:42am

@gwansikk gwansikk marked this pull request as ready for review February 4, 2025 06:43
@gwansikk gwansikk requested a review from jungpaeng as a code owner February 4, 2025 06:43
Copy link
Member

@evan-moon evan-moon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.24%. Comparing base (7dc3a45) to head (569987e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   84.24%   84.24%           
=======================================
  Files          13       13           
  Lines         273      273           
  Branches       55       55           
=======================================
  Hits          230      230           
  Misses         40       40           
  Partials        3        3           
Components Coverage Δ
overlay-kit 84.24% <ø> (ø)

Copy link
Member

@jungpaeng jungpaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jungpaeng jungpaeng merged commit 9945f49 into toss:main Feb 5, 2025
10 checks passed
@gwansikk gwansikk deleted the fix/typo branch February 5, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants