Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API endpoint for listing users #788

Merged

Conversation

mario-nt
Copy link
Contributor

@mario-nt mario-nt commented Dec 14, 2024

Parent issue #658
Resolves #796

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 27.20000% with 91 lines in your changes missing coverage. Please review.

Project coverage is 48.53%. Comparing base (3bd92fa) to head (1c62a9e).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
src/services/user.rs 23.91% 35 Missing ⚠️
src/databases/mysql.rs 0.00% 22 Missing ⚠️
src/databases/sqlite.rs 0.00% 22 Missing ⚠️
src/web/api/server/v1/contexts/user/handlers.rs 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #788      +/-   ##
===========================================
- Coverage    48.85%   48.53%   -0.33%     
===========================================
  Files          111      111              
  Lines         8288     8413     +125     
  Branches      8288     8413     +125     
===========================================
+ Hits          4049     4083      +34     
- Misses        4101     4192      +91     
  Partials       138      138              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mario-nt mario-nt force-pushed the 658-admins-should-be-able-to-list-users branch from 490eb1e to 453f02d Compare January 8, 2025 15:52
@mario-nt mario-nt force-pushed the 658-admins-should-be-able-to-list-users branch from 453f02d to 5ff61f4 Compare January 8, 2025 16:02
@mario-nt mario-nt force-pushed the 658-admins-should-be-able-to-list-users branch from 5ff61f4 to e8bd16d Compare January 8, 2025 16:03
@mario-nt mario-nt force-pushed the 658-admins-should-be-able-to-list-users branch from 590b20b to b44ea9b Compare January 8, 2025 16:51
@mario-nt mario-nt marked this pull request as ready for review January 15, 2025 13:11
@mario-nt mario-nt requested a review from josecelano January 15, 2025 13:11
@mario-nt mario-nt marked this pull request as draft January 15, 2025 16:08
@mario-nt mario-nt marked this pull request as ready for review January 16, 2025 20:20
@mario-nt mario-nt marked this pull request as draft January 19, 2025 16:51
Copy link
Member

@josecelano josecelano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mario-nt it looks good! I think you could also add some tests like the ones we have for the torrent context. You can do it in a new PR.

@josecelano josecelano self-requested a review January 22, 2025 07:28
Copy link
Member

@josecelano josecelano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mario-nt the testing workflow is failing.

@mario-nt mario-nt force-pushed the 658-admins-should-be-able-to-list-users branch from 81198c9 to 1c62a9e Compare January 22, 2025 10:54
@mario-nt mario-nt marked this pull request as ready for review January 22, 2025 10:55
@josecelano josecelano self-requested a review January 22, 2025 13:34
@josecelano
Copy link
Member

ACK 1c62a9e

@josecelano josecelano merged commit 33392f4 into torrust:develop Jan 22, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New API endpoint for listing users
2 participants