-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New API endpoint for listing users #788
New API endpoint for listing users #788
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #788 +/- ##
===========================================
- Coverage 48.85% 48.53% -0.33%
===========================================
Files 111 111
Lines 8288 8413 +125
Branches 8288 8413 +125
===========================================
+ Hits 4049 4083 +34
- Misses 4101 4192 +91
Partials 138 138 ☔ View full report in Codecov by Sentry. |
b44d54f
to
f48c4a2
Compare
490eb1e
to
453f02d
Compare
453f02d
to
5ff61f4
Compare
5ff61f4
to
e8bd16d
Compare
590b20b
to
b44ea9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mario-nt it looks good! I think you could also add some tests like the ones we have for the torrent context. You can do it in a new PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mario-nt the testing workflow is failing.
81198c9
to
1c62a9e
Compare
ACK 1c62a9e |
Parent issue #658
Resolves #796