Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWE-17 | FE | Primary nav and header #346

Merged

Conversation

albinazs
Copy link
Collaborator

@albinazs albinazs commented Jan 20, 2025

Link to Ticket

Description of Changes Made

Primary navigation and header FE:

  • Update header styles
  • Simplified primary nav structure (no children)
  • New compact mobile menu dropdown that opens on clicking the toggle and closes on clicking outside
  • Adjust focus-style mixin to handle keyboard interaction only - as an option (used for the menu toggle)
  • Mode switcher visible for now (I will hide it once the changes are approved)

Note: later we'll work with Amanda on updating the mobile menu toggle button text depending on the context (Division name for Division page and all the descendants)

How to Test

Open the home page or the component in the DPL: http://0.0.0.0:8000/pattern-library/pattern/patterns/organisms/header/header.html

Screenshots

Expand to see more
Screen.Recording.2025-01-20.at.6.59.05.PM.mov

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@albinazs albinazs self-assigned this Jan 20, 2025
@albinazs
Copy link
Collaborator Author

thank you, @chris-lawton - good catches!:)
all the suggestions are addressed

@albinazs albinazs merged commit 315ee0b into integration/2024-evolution Jan 21, 2025
4 checks passed
@albinazs albinazs deleted the feature/twe-17-primary-nav-and-header branch January 21, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants