Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWE-14 | FE | Contact CTA redesign #341

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

shyusu4
Copy link
Collaborator

@shyusu4 shyusu4 commented Jan 14, 2025

Link to Ticket

Description of Changes Made

  • Styled the contact CTA and CTA components according to the design
  • Additional change (as discussed with Ben E.) - Since the original design text did not meet the minimum color contrast requirements, the text font-size was increased to pass this

How to Test

Open the contact_call_to_action block through the pattern library (http://localhost:8000/pattern-library/render-pattern/patterns/molecules/streamfield/blocks/contact_call_to_action.html) and call_to_action (http://localhost:8000/pattern-library/render-pattern/patterns/molecules/streamfield/blocks/call_to_action.html)

Screenshots

Expand to see more

Screenshot (122)
Screenshot (123)
Screenshot (124)

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@shyusu4 shyusu4 changed the title TWE-14 | FE| Contact CTA redesign TWE-14 | FE | Contact CTA redesign Jan 14, 2025
@shyusu4 shyusu4 requested a review from albinazs January 17, 2025 09:02
@shyusu4 shyusu4 marked this pull request as ready for review January 17, 2025 09:02
@albinazs
Copy link
Collaborator

I briefly looked at the CTA component, and all looks good except for the contrast issues with the name and the button text. We'll need to discuss with Ben E. how to adjust the design to make this component accessible.

@shyusu4 shyusu4 removed the request for review from albinazs January 17, 2025 09:25
@shyusu4 shyusu4 requested a review from chris-lawton January 20, 2025 11:24
Copy link
Member

@chris-lawton chris-lawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @shyusu4 - looks great!

@shyusu4
Copy link
Collaborator Author

shyusu4 commented Jan 21, 2025

thank you, @chris-lawton! I've committed your suggestions so should look fine now - I'll go ahead and merge this : )

@shyusu4 shyusu4 merged commit debb678 into feature/14-contact-cta-description Jan 21, 2025
4 checks passed
@shyusu4 shyusu4 deleted the feature/14-contact-cta-FE branch January 21, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants