-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TWE-14 | FE | Contact CTA redesign #341
TWE-14 | FE | Contact CTA redesign #341
Conversation
I briefly looked at the CTA component, and all looks good except for the contrast issues with the name and the button text. We'll need to discuss with Ben E. how to adjust the design to make this component accessible. |
...oject_styleguide/templates/patterns/molecules/streamfield/blocks/contact_call_to_action.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @shyusu4 - looks great!
thank you, @chris-lawton! I've committed your suggestions so should look fine now - I'll go ahead and merge this : ) |
Link to Ticket
Description of Changes Made
How to Test
Open the contact_call_to_action block through the pattern library (http://localhost:8000/pattern-library/render-pattern/patterns/molecules/streamfield/blocks/contact_call_to_action.html) and call_to_action (http://localhost:8000/pattern-library/render-pattern/patterns/molecules/streamfield/blocks/call_to_action.html)
Screenshots
Expand to see more
MR Checklist
Unit tests
Documentation
Browser testing
Data protection
Light and dark mode
Accessibility
Sustainability
Pattern library