TWE-16 - BE - Optional intro & button fields for blog/work chooser blocks #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SharmaineLim
changed the title
31 tasks
engineervix
approved these changes
Jan 31, 2025
| <ul class="grid__related-posts streamfield__related-posts mb-spacerMedium lg:mb-spacerLarge"> | ||
| {% for blog_page in value.blog_pages %} | ||
| {% pageurl blog_page.blog_index as blog_index_url %} | ||
| {% pageurl blog_page as blog_post_url %} | ||
| {% include "patterns/molecules/listing/listing--avatar.html" with title=blog_page.title name=blog_page.first_author.name job_title=blog_page.first_author.role link=blog_post_url date=blog_page.date reading_time=blog_page.read_time tags=blog_page.tags avatar=blog_page.first_author.image tag_link_base=blog_index_url %} | ||
| {% endfor %} | ||
| </ul> | ||
|
|
There was a problem hiding this comment.
Suggestion(non-blocking): What do you think about adding a small comment here, along the lines of
Suggested change
| {# We expect only 1 button (`max_num=1` in block definition) #} |
| {% for button in value.primary_button %} | ||
| <a href="{{ button.value.url }}">{{ button.value.text }}</a> | ||
| {% endfor %} | ||
|
|
There was a problem hiding this comment.
Suggestion(non-blocking): ditto
Suggested change
| {# We expect only 1 button (`max_num=1` in block definition) #} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Ticket
Description of Changes Made
This PR introduces an
introrich text field, aprimary_button, and asecondary_buttonto the blog chooser block and the work chooser block.Additionally, it introduces a
primary_buttonandsecondary_buttonto both blocks.How to Test
Screenshots
Page editor
MR Checklist
Unit tests
Documentation
Browser testing
Data protection
Light and dark mode
Accessibility
Sustainability
Pattern library