-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jinja templates #206
base: main
Are you sure you want to change the base?
Jinja templates #206
Conversation
We got overriting the extends and includes tags working, so I think this is ready for review! |
Omg! Thank you @gone, I’ll find some time to review this properly. |
Cool yeah, happy to make any changes! |
@gone I opened a PR to your branch fixing some issues, but I could also open a new one directly here if it's easier for @thibaudcolas to review the entire thing at once. Let me know what you folks prefer. |
Hey @gone 👋🏼 I've opened up a PR to your repo here: gone#6 @thibaudcolas If it's easier, I can open it up directly on the Torchbox upstream. Please let me know what you folks would prefer. Many thanks! 🙌🏼 |
Description
This is a first pass at jinja support.
Right now this supports the major features I can account for, outside of overriding extends and includes tags.
I haven't really checked against the styleguide/updated documentation/tests so I think this is just in wip status
Fixes # (issue) #171
Checklist