Use current time to update latest stock list info from official sites #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paullo0106 這遇到六日或是沒開市日就抓不到資料 XD，不過感謝你的 PR，我這禮拜加入，感謝你。 |
|
Oh yeah, I didn't think of weekend issue. |
added 3 commits
November 26, 2014 14:27
…csv from a latest validate day
|
@toomore 針對你提的"六日或是沒開市日"的問題，我剛才加了一些程式碼: base on你原本的TWSEOpen d_day()延伸了一個recent_open_day() function，如果今天沒開市就往前一天去check，直到有開市的那天為止。 (原本在想會不會有infinite loop，但我還沒有試出這樣的日期，看起來d_day()支援的時間區間似乎滿完整的) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be more convenient and make more sense to use the current time rather than a hard-coded past time for generating csv files of the latest stock info, that's the main reason I made those changes :p