Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle the removal of the p5 instance #329

Closed
wants to merge 1 commit into from
Closed

fix: handle the removal of the p5 instance #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/lib/P5.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script lang="ts">
import { onMount, createEventDispatcher } from 'svelte';
import { onMount, onDestroy, createEventDispatcher } from 'svelte';
import type p5 from 'p5';
import type { Sketch } from '$lib/types';

Expand Down Expand Up @@ -76,6 +76,16 @@
dispatch.ref();
dispatch.instance();
});

/**
* Bind the lifecycle of the p5 instance with the component
*/
onDestroy(() => {
if (project) {
project.remove()
project = undefined
}
})
</script>

<div use:ref style={parentDivStyle} class="m-0" />