Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rm2fb to v0.0.4 #363

Merged
merged 2 commits into from
Jun 6, 2021
Merged

Update rm2fb to v0.0.4 #363

merged 2 commits into from
Jun 6, 2021

Conversation

matteodelabre
Copy link
Member

This update includes a change in the server code to set the server process name to 'rm2fb-server' (instead of the default 'xochitl'). See also #359 and rmkit-dev/rmkit#127. I also removed Toltec’s patch to set argv[0] since it’s included in upstream now.

Test plan: Started the 'rm2fb' service, retrieved the server PID, and made sure that both /proc/PID/cmdline and /proc/PID/stat contained 'rm2fb-server' instead of 'xochitl'.

This update includes a change in the server code to set the server
process name to 'rm2fb-server' (instead of the default 'xochitl'). See
also #359 and rmkit-dev/rmkit#127.

Test plan: Started the 'rm2fb' service, retrieved the server PID, and
made sure that both `/proc/PID/cmdline` and `/proc/PID/stat` contained
'rm2fb-server' instead of 'xochitl'.
@matteodelabre matteodelabre added the packages Add or improve packages of the repository label Jun 4, 2021
@matteodelabre matteodelabre requested a review from raisjn June 4, 2021 09:59
@Eeems
Copy link
Member

Eeems commented Jun 4, 2021

Installed fine for me on rM1 with no bad side effects.

@JanLuca
Copy link

JanLuca commented Jun 6, 2021

Installed and works fine for me on rM2. Thank you for updating the package!

Copy link
Contributor

@raisjn raisjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(based on jan's testing)

@matteodelabre
Copy link
Member Author

Thanks all for providing additional testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Add or improve packages of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants