Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs splitter and cross encoder based re-ranker; #5

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Add docs splitter and cross encoder based re-ranker; #5

merged 1 commit into from
Nov 6, 2024

Conversation

ranjan-stha
Copy link
Collaborator

Changes

  • Added the re-ranker using cross encoder
  • Added the token based docs splitting method.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)

@ranjan-stha ranjan-stha requested a review from sudan45 November 6, 2024 05:07
@ranjan-stha ranjan-stha force-pushed the feat/docs-post-process branch from aca0941 to b32f641 Compare November 6, 2024 05:15
@sudan45 sudan45 merged commit 6386f2b into develop Nov 6, 2024
2 checks passed
@sudan45 sudan45 deleted the feat/docs-post-process branch November 6, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudan45 sudan45 sudan45 approved these changes

Assignees

@udaynwa udaynwa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ranjan-stha @sudan45 @udaynwa