Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window deletion from session #503

Closed

Conversation

Moysenko
Copy link

@Moysenko Moysenko commented Oct 22, 2023

  1. Based on isintance(target_window, int), I made corrections to typing. Also added is not None to if target_window just in case of target_window == 0
  2. Case 2 from man http://man.openbsd.org/OpenBSD-current/man1/tmux.1#:~:text=target%2D-,window,-(or%20src%2Dwindow was incorrectly implemented. There should be the current session, not the current window
  3. If no argument is passed, old implementation of kill_window just crashed. I fixed it
  4. Added test and docs

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2023

CLA assistant check
All committers have signed the CLA.

@Moysenko Moysenko force-pushed the fix-window-deletion-from-session branch from dceb1a6 to b172f49 Compare October 22, 2023 22:22
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #503 (b172f49) into master (b2302c8) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
+ Coverage   88.84%   88.96%   +0.11%     
==========================================
  Files          35       35              
  Lines        3514     3524      +10     
  Branches      484      487       +3     
==========================================
+ Hits         3122     3135      +13     
+ Misses        284      283       -1     
+ Partials      108      106       -2     
Files Coverage Δ
src/libtmux/session.py 77.83% <100.00%> (+1.71%) ⬆️
tests/test_session.py 97.23% <100.00%> (+0.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony force-pushed the master branch 2 times, most recently from f15027f to 8baa764 Compare February 17, 2024 13:33
@tony tony closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants