Cleaned up the bingads error messages on bing reports.

tmarois · Dec 12, 2019 · c7d335b · c7d335b
1 parent e77656e
commit c7d335b
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 24 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,11 @@
 Change Log
 ==========
 
+### 12/12/2019 - 1.2.14
+
+#### Changed
+* Cleaned up `BingAds` for Soap errors due to request of `__getLastRequest()` undefined errors.  
+
 ### 11/07/2019 - 1.2.13
 
 #### Added

diff --git a/src/Services/BingAds/Reports.php b/src/Services/BingAds/Reports.php
@@ -318,12 +318,16 @@ public function buildFinalUrlReport()
         }
         catch (SoapFault $e)
         {
-        	printf("-----\r\nFault Code: %s\r\nFault String: %s\r\nFault Detail: \r\n", $e->faultcode, $e->faultstring);
-            var_dump($e->detail);
-        	print "-----\r\nLast SOAP request/response:\r\n";
-            print $this->serviceProxy->GetWsdl() . "\r\n";
-        	print $this->serviceProxy->__getLastRequest()."\r\n";
-            print $this->serviceProxy->__getLastResponse()."\r\n";
+            printf("-----\r\nFault Code: %s\r\nFault String: %s\r\nFault Detail: \r\n", $e->faultcode, $e->faultstring);
+
+            if (isset($e->detail)) {
+                var_dump($e->detail);
+            }
+
+        	// print "-----\r\nLast SOAP request/response:\r\n";
+            // print $this->serviceProxy->GetWsdl() . "\r\n";
+        	// print $this->serviceProxy->__getLastRequest()."\r\n";
+            // print $this->serviceProxy->__getLastResponse()."\r\n";
         }
 
         return (new ReportDownload($this->serviceProxy, $reportRequestId));
@@ -373,12 +377,16 @@ public function buildSearchTermReport()
         }
         catch (SoapFault $e)
         {
-        	printf("-----\r\nFault Code: %s\r\nFault String: %s\r\nFault Detail: \r\n", $e->faultcode, $e->faultstring);
-            var_dump($e->detail);
-        	print "-----\r\nLast SOAP request/response:\r\n";
-            print $this->serviceProxy->GetWsdl() . "\r\n";
-        	print $this->serviceProxy->__getLastRequest()."\r\n";
-            print $this->serviceProxy->__getLastResponse()."\r\n";
+            printf("-----\r\nFault Code: %s\r\nFault String: %s\r\nFault Detail: \r\n", $e->faultcode, $e->faultstring);
+
+            if (isset($e->detail)) {
+                var_dump($e->detail);
+            }
+
+        	// print "-----\r\nLast SOAP request/response:\r\n";
+            // print $this->serviceProxy->GetWsdl() . "\r\n";
+        	// print $this->serviceProxy->__getLastRequest()."\r\n";
+            // print $this->serviceProxy->__getLastResponse()."\r\n";
         }
 
         return (new ReportDownload($this->serviceProxy, $reportRequestId));
@@ -431,12 +439,16 @@ public function buildAgeGenderReport()
         }
         catch (SoapFault $e)
         {
-        	printf("-----\r\nFault Code: %s\r\nFault String: %s\r\nFault Detail: \r\n", $e->faultcode, $e->faultstring);
-            var_dump($e->detail);
-        	print "-----\r\nLast SOAP request/response:\r\n";
-            print $this->serviceProxy->GetWsdl() . "\r\n";
-        	print $this->serviceProxy->__getLastRequest()."\r\n";
-            print $this->serviceProxy->__getLastResponse()."\r\n";
+            printf("-----\r\nFault Code: %s\r\nFault String: %s\r\nFault Detail: \r\n", $e->faultcode, $e->faultstring);
+
+            if (isset($e->detail)) {
+                var_dump($e->detail);
+            }
+
+        	// print "-----\r\nLast SOAP request/response:\r\n";
+            // print $this->serviceProxy->GetWsdl() . "\r\n";
+        	// print $this->serviceProxy->__getLastRequest()."\r\n";
+            // print $this->serviceProxy->__getLastResponse()."\r\n";
         }
 
         return (new ReportDownload($this->serviceProxy, $reportRequestId));
@@ -495,12 +507,16 @@ public function buildMostSpecificLocationReport()
         }
         catch (SoapFault $e)
         {
-        	printf("-----\r\nFault Code: %s\r\nFault String: %s\r\nFault Detail: \r\n", $e->faultcode, $e->faultstring);
-            var_dump($e->detail);
-        	print "-----\r\nLast SOAP request/response:\r\n";
-            print $this->serviceProxy->GetWsdl() . "\r\n";
-        	print $this->serviceProxy->__getLastRequest()."\r\n";
-            print $this->serviceProxy->__getLastResponse()."\r\n";
+            printf("-----\r\nFault Code: %s\r\nFault String: %s\r\nFault Detail: \r\n", $e->faultcode, $e->faultstring);
+
+            if (isset($e->detail)) {
+                var_dump($e->detail);
+            }
+
+        	// print "-----\r\nLast SOAP request/response:\r\n";
+            // print $this->serviceProxy->GetWsdl() . "\r\n";
+        	// print $this->serviceProxy->__getLastRequest()."\r\n";
+            // print $this->serviceProxy->__getLastResponse()."\r\n";
         }
 
         return (new ReportDownload($this->serviceProxy, $reportRequestId));