Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

olevba: add page #15554

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

olevba: add page #15554

wants to merge 5 commits into from

Conversation

est15
Copy link

@est15 est15 commented Jan 19, 2025

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@est15 est15 requested a review from cyqsimon as a code owner January 19, 2025 20:28
@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Jan 19, 2025
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/linux/olevba.md:28: TLDR103 Command example is missing its closing backtick

Please fix the error(s) and push again.

Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have some suggestions, after which I think this page is good to go 👍 Also, is this tool linux-only? If not, we should move it to the common directory.

pages/linux/olevba.md Outdated Show resolved Hide resolved
pages/linux/olevba.md Outdated Show resolved Hide resolved
pages/linux/olevba.md Outdated Show resolved Hide resolved

> Parse OLE and OpenXML files (e.g., DOC, XLS, PPT, etc.) to extract VBA macros, deobfuscate, and analyze malicious code.
> Part of the `python-oletools` suite.
> For more information: <http://decalage.info/python/oletools>.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "more information" link is just a blank page for me. Not sure if this is temporary or if it's been broken for a while. We can link to the GitHub page if needed

Suggested change
> For more information: <http://decalage.info/python/oletools>.
> For more information: <https://github.com/decalage2/oletools>.

@nelsonfigueroa
Copy link
Collaborator

Left a suggestion. Also, as @gutjuri said, if this isn't a linux-only tool we should move this .md file to the common directory. Based on the GitHub README it looks like this is indeed a multi-platform tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants