Development #97
Merged
Development #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release v1.1
Update development with new release and hotfixes
…reached exit solve after iter_limit reached
…ive-flux Feature change err for negative flux resolves #94
calc vertical flux function
|
solves #91 by calling s.calc_vertical_flux() after solve |
|
solves #100 |
Closed
daubners
reviewed
Oct 28, 2024
There was a problem hiding this comment.
Lines 49-51 and and 344-346 seem to be redundant
There was a problem hiding this comment.
Thanks, deleted them, check out my latest commit.
daubners
approved these changes
Nov 4, 2024
| @@ -491,10 +498,15 @@ def check_convergence(self, verbose, conv_crit, start, iter_limit): | |||
|
|
|||
| return False | |||
|
|
|||
| def check_vertical_flux(self, conv_crit): | |||
| def calc_vertical_flux(self): | |||
There was a problem hiding this comment.
Is this different for every solver or could it simply be inherited?
| vert_flux = (self.conc[:, 1:-1, 1:-1, 1:-1] - self.conc[:, | ||
| :-2, 1:-1, 1:-1]) * self.pre_factors[1][:, :-2, 1:-1, 1:-1] | ||
| vert_flux[self.nn == torch.inf] = 0 | ||
| return vert_flux | ||
|
|
||
| def check_vertical_flux(self, conv_crit): |
There was a problem hiding this comment.
Inheritance? see question above
This was referenced Nov 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the iter limit reach and negative flux convergence issues.