Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface areas #107

Merged
merged 12 commits into from
Jan 22, 2025
Merged

Surface areas #107

merged 12 commits into from
Jan 22, 2025

Conversation

daubners
Copy link
Contributor

Add more elaborate surface area computation.
specific_surface_area() now takes method= as input which can be

  • 'gradient' for fast phase-field approach
  • 'face_counting' for face counting or
  • 'marching_cubes' for marching cubes method

The first method is fully compatible with anisotropic voxels and roughly by a factor of ten faster than marching cubes.
This branch is based on pull request #106 and should be merged afterwards.
This branch solves issue #93.

@daubners daubners requested a review from amirDahari1 January 21, 2025 20:54
Copy link
Member

@amirDahari1 amirDahari1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I assume you've tested it :)

@amirDahari1 amirDahari1 merged commit f326b21 into tldr-group:main Jan 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants